Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client):job info error at cloud instance #1226

Merged
merged 2 commits into from
Sep 16, 2022
Merged

fix(client):job info error at cloud instance #1226

merged 2 commits into from
Sep 16, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Sep 16, 2022 •
edited
Loading

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added bug 🐛 Something isn't working ban-e2e 🚫 labels Sep 16, 2022
@goldenxinxing goldenxinxing self-assigned this Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022 •
edited
Loading

Codecov Report

Merging #1226 (5e32fd1) into main (ba0710e) will increase coverage by 10.87%.
The diff coverage is 91.66%.

@@              Coverage Diff              @@
##               main    #1226       +/-   ##
=============================================
+ Coverage     70.89%   81.76%   +10.87%     
=============================================
  Files           284       62      -222     
  Lines         13098     6966     -6132     
  Branches        637        0      -637     
=============================================
- Hits           9286     5696     -3590     
+ Misses         3615     1270     -2345     
+ Partials        197        0      -197
Flag Coverage Δ
controller ?
standalone 81.76% <91.66%> (+0.01%) ⬆️
unittests 81.76% <91.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/eval/model.py 77.47% <ø> (ø)
client/starwhale/core/eval/view.py 65.76% <66.66%> (-0.16%) ⬇️
client/starwhale/api/_impl/data_store.py 96.00% <100.00%> (+<0.01%) ⬆️
client/starwhale/api/_impl/wrapper.py 89.24% <100.00%> (ø)
.../domain/system/resourcepool/ResourcePoolCache.java
.../starwhale/mlops/exception/SwProcessException.java
.../starwhale/mlops/domain/bundle/tag/TagManager.java
...in/task/status/watchers/TaskWatcherForPersist.java
.../starwhale/mlops/common/VersionAliasConvertor.java
...i/starwhale/mlops/domain/system/SystemService.java
... and 217 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tianweidut
tianweidut approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit e22bc5c into star-whale:main Sep 16, 2022
@goldenxinxing goldenxinxing deleted the fix/cloud_instance_info_error branch April 27, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

Assignees

@goldenxinxing goldenxinxing

Labels
ban-e2e 🚫 bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldenxinxing @tianweidut